Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #1079

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Add integration tests #1079

merged 7 commits into from
Jan 12, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 12, 2024

This PR adds integration tests, to be executed when ENV["TEST_MLJ_INTEGRATION"] == "true". They take about an hour to execute.

The tests use MLJTestIntegration 0.5.0. The PR adds all the model-providing packages to the project as [extras], which does add some precompilation overhead to tests, even when the flag is set to false. They may be ways to avoid this, but I expect they add some complication. In any case, this is experimental. Hopefully, there will be no affect the casual user.

The PR has the flag set to "true" for PR's with dev as source.

@ablaom ablaom merged commit 3a294de into dev Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant