Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to LossFunctions.jl v0.9 #896

Closed
juliohm opened this issue Apr 18, 2023 · 2 comments · Fixed by #898
Closed

Update to LossFunctions.jl v0.9 #896

juliohm opened this issue Apr 18, 2023 · 2 comments · Fixed by #898
Assignees
@ablaom

Comments

@juliohm
Copy link
Contributor

juliohm commented Apr 18, 2023

@ablaom we refactored LossFunctions.jl and changed the order of output and prediction arguments to be more consistent with other ecosystems as you requested at some point in the past. Can you please update this package to use the latest release?

We also removed the ObsDim submodule and the OrdinalMarginLoss as they were not very useful nor very used in downstream projects we maintain.
@juliohm
Copy link
Contributor Author

juliohm commented Apr 19, 2023

cc: @OkonSamuel

@ablaom
Copy link
Member

ablaom commented Apr 19, 2023

@juliohm Thanks for flagging.

@ablaom ablaom mentioned this issue Apr 19, 2023
Closed
@ablaom ablaom self-assigned this Apr 20, 2023
@ablaom ablaom mentioned this issue Apr 20, 2023
Merged
@ablaom ablaom mentioned this issue Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ablaom ablaom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump compat LossFunctions = "0.9" and address breakage JuliaAI/MLJBase.jl
2 participants
@juliohm @ablaom