Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the comments at JuliaAI/MLJ.jl#1016, this PR suggests adding a precompile workload here to
MLJBase.jl
.I'm running a bit into an issue though. I can't run
evaluate!
because that one callsMLJModelInterface.nrows
atsrc/resampling.jl#1289
. As far as I understand, the problem is that the interface mode inMLJModelInterface
(INTERFACE_MODE
) is not set during precompilation yet. However, I also cannot set the global constant because that will likely "bake in" the constant during precompilation via constant propagation, which then could give problems later on.Is there a way we could get rid of the global constant? Maybe that could make precompilation easier. This might also have some other benefits down the line. I do understand that it's a big ask, though, so we can also continue without calling
evaluate!
.