improve show of confusion matrix by finding optimal column width (cw) #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is claulcated based on the maximal values and lebel width
while ensuring the table header ("Gorubnd Truth") has enough width
and the first column (firstcw) has enough space for "Predicted" header
|
@Roeya This looks great. Appreciate the contribution! Can you please make your PR on the default Alternatively, in view of #909, you could make a PR at StatisticalMeasures.jl. That'd be my preference, unless you want this in a hurry. Or we could do PR's here and at StatisticalMeasures.jl. |
|
Ok - I'll PR the dev, I'll also PR StatisticalMeasures.jl later |
|
I'm expecting another PR to be merged today/tomorrow, so will hold off tagging a new release until then. |
This was referenced Aug 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is calculated based on the maximal values and label width while ensuring the table header ("Ground Truth") has enough width and the first column (firstcw) has enough space for "Predicted" header.
The test where also updated.