Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target as alias for transformer in TransformedTargetModel #933

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Sep 22, 2023

Closes #856.

For release notes:

@ablaom ablaom mentioned this pull request Sep 22, 2023
4 tasks
@ablaom ablaom changed the base branch from dev to for-a-0-point-22-release September 22, 2023 05:36
@ablaom ablaom closed this Sep 22, 2023
@ablaom ablaom reopened this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (fa955a5) 86.21% compared to head (444087e) 86.20%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           for-a-0-point-22-release     #933      +/-   ##
============================================================
- Coverage                     86.21%   86.20%   -0.02%     
============================================================
  Files                            27       27              
  Lines                          2531     2529       -2     
============================================================
- Hits                           2182     2180       -2     
  Misses                          349      349              
Files Changed Coverage Δ
src/composition/models/pipelines.jl 97.25% <ø> (-0.02%) ⬇️
src/composition/models/transformed_target_model.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom merged commit e61f43a into for-a-0-point-22-release Sep 22, 2023
8 checks passed
@ablaom ablaom deleted the transformed-target-alias-remove branch September 22, 2023 09:15
This was referenced Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove target as alias for transformer in TransformedTarget(transformer=...)
1 participant