Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Documenter v1 for the PkgTemplates repo itself #435

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Upgrade to Documenter v1 for the PkgTemplates repo itself #435

merged 1 commit into from
Oct 17, 2023

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Oct 12, 2023

  • Add compat lower bound to docs/Project.toml
  • Gitignore docs/Manifest.toml
  • Tweak docs/make.jl
  • Insert missing docstrings ( Formatter, CodeOwners, pkg_name and PkgTemplates itself)

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #435 (57a20dd) into master (e21f2fb) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #435   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files          23       23           
  Lines         713      713           
=======================================
  Hits          664      664           
  Misses         49       49

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gdalle
Copy link
Collaborator Author

gdalle commented Oct 16, 2023

Ping @oxinabox this is a lightning fast review

oxinabox
oxinabox approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
(btw if ever in a hurry few reviews pinging me on slack is best)

@gdalle
Copy link
Collaborator Author

gdalle commented Oct 17, 2023

Cool, thanks

@gdalle gdalle merged commit 420dadd into master Oct 17, 2023
13 checks passed
@gdalle gdalle deleted the gd/documenter1 branch October 17, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdalle @oxinabox