Update macOS CI #570
Merged
Update macOS CI #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, macOS-latest x64 is emulating x64 on aarch64 (actions/runner-images#9741). Should this be macos-13 x64 instead?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 97.84% 97.40% -0.45%
==========================================
Files 18 16 -2
Lines 3199 3193 -6
==========================================
- Hits 3130 3110 -20
- Misses 69 83 +14 ☔ View full report in Codecov by Sentry. |
|
Hm... using |
|
Yes, aarch64 should be macos-latest now. |
|
No clue why codecov/project is failing but doesn't seem major. |
martinholters
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since macOS-latest now points to macos-14.
Also, the macOS-latest x64 job currently emulates x64 on aarch64 (actions/runner-images#9741). Should this be macos-13 x64 instead?