Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy-paste old arrow code into subdir to remove Arrow package dependency #145

Merged
merged 7 commits into from
Nov 20, 2020
Merged

Copy-paste old arrow code into subdir to remove Arrow package dependency #145

merged 7 commits into from
Nov 20, 2020

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Nov 20, 2020

No description provided.

@quinnj quinnj mentioned this pull request Nov 20, 2020
Closed
@quinnj
Copy link
Member Author

quinnj commented Nov 20, 2020

Hmmm, we seem to have bigger compat problems; the arrow code is doing getlevels(x::CategoricalArray) = x.pool.index which seems to not be valid in newer CategoricalArrays releases; but if we put upper bounds on CAs.jl, then that makes the DataFrames.jl bump not work. @nalimilan any advice?

@quinnj
Copy link
Member Author

quinnj commented Nov 20, 2020

Ok, looks like we should just be calling levels(c); so let's see how CI likes this

nalimilan
nalimilan approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Actually I hadn't seen your PR and I started applying the same fix here: apache/arrow-julia#70. :-)

@nalimilan nalimilan mentioned this pull request Nov 20, 2020
Closed
@nalimilan
Copy link
Member

Failures on 32-bit Windows seem to be due to passing an Int64 to fieldtype. That's weird since Tables.columnindex seems to always return an Int, but maybe just do fieldtype(T, Int(col)).

nalimilan
nalimilan reviewed Nov 20, 2020
View reviewed changes
Manifest.toml Outdated
@@ -0,0 +1,231 @@
# This file is machine-generated - editing it directly is not advised
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to commit this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope!

@nalimilan
Copy link
Member

32-bit Windows still fails, but looking at the AppVeyor log, the fieldtype failure has been there for at least one year so this PR doesn't make things worse.

@quinnj quinnj merged commit afe3d0b into master Nov 20, 2020
@quinnj quinnj deleted the jq/arrow branch November 20, 2020 22:16
@nalimilan
Copy link
Member

Should we tag a release now?

@quinnj
Copy link
Member Author

quinnj commented Nov 20, 2020

Tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quinnj @nalimilan