add GeoInterfaceMakie #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3126
commented
Oct 11, 2022
|
TODO I guess I should add CI for this subpackage. |
jw3126
commented
Oct 12, 2022
rafaqz
reviewed
Oct 13, 2022
|
@rafaqz poly is now available in MakieCore and tests pass here without depending on Makie! |
|
Thanks for merging! Can you register GeoInterfaceMakie? |
|
Sure! Kind of annoying for you writing a package and you cant administer it. Do you want to be a moderator/admin here? |
|
Yes would be great if I could do more things myself here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.