Glyph indices #72
Merged
Glyph indices #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 91.26% 94.62% +3.35%
==========================================
Files 6 6
Lines 332 316 -16
==========================================
- Hits 303 299 -4
+ Misses 29 17 -12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the base glyph representation to a UInt64 index, which can directly pick a glyph out of a font without the unicode char detour. This allows the methods to work for special scenarios like in MathTeXEngine.jl
The old way of accessing things via Char should still work, they are just converted to UInt64 indices along the way. The same for
Stringwhich can access a glyph by name if there's one (likeintegral.v1).Because of the string name based glyph finding, and because that functionality is not used anymore in Makie (and elsewhere?) I've removed methods for simple string layouts / boundingboxes.