This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Reduce specialization in GLib methods #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of these methods run on non-inferrable argument types. Consequently it seems to make sense to reduce the amount of specialization. Note there's one case with *increased* specialization, to make it more reliably inferrable and thus precompilable.
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 47.54% 47.61% +0.07%
==========================================
Files 32 32
Lines 2381 2390 +9
==========================================
+ Hits 1132 1138 +6
- Misses 1249 1252 +3
Continue to review full report at Codecov.
|
|
I'll merge soon barring objections. |
|
go ahead, I cannot really review that because you are far ahead in knowledge about all this specialization stuff. |
timholy
added a commit
that referenced
this pull request
Dec 6, 2021
As a consequence of the forced specialization on the `RT` argument of `signal_emit` in #552, the compiler now knows whether `RT === Nothing`. In that case, it also knows that `return_value` will not be used, so it is free to be garbage-collected. When that happens, it triggers segfaults. This puts both potential `GValue`-arguments inside a `GC.@preserve` to prevent garbage collection. Fixes #581.
timholy
added a commit
that referenced
this pull request
Dec 6, 2021
As a consequence of the forced specialization on the `RT` argument of `signal_emit` in #552, the compiler now knows whether `RT === Nothing`. In that case, it also knows that `return_value` will not be used, so it is free to be garbage-collected. When that happens, it triggers segfaults. This puts both potential `GValue`-arguments inside a `GC.@preserve` to prevent garbage collection. Fixes #581.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of these methods run on non-inferrable argument types.
Consequently it seems to make sense to reduce the amount of
specialization.
Note there's one case with increased specialization, to make it
more reliably inferrable and thus precompilable.
I think all of these make sense, but if anyone can review it I would certainly appreciate it.