-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageMagick should be in the [deps] section in Project.toml #824
Comments
Adding
In this case, you don't need |
Exactly. Moreover, depending on platform the user may prefer different packages (e.g., QuartzImageIO on macs). |
You are totally right, I feel a bit stupid... Thanks for responding - and solving this! |
This seems related; let me know if you'd prefer that I open a new issue... I tried following the "Getting started" instructions:
It seems to me like ImageMagick should in fact be installed as a dep of Images.jl... |
FileIO used to prompt to install image io backends if not available, now it doesn't do this anymore and just throw an error for that. We've updated the docs recently JuliaImages/juliaimages.github.io#115. Unfortunately, the documentation CI is continuously hitting failures during deployment, you can view the latest version of "getting started" by this: https://juliaimages.org/previews/PR115/install/ |
I believe the reason we didn't do this for Images.jl is that binary dependency was a maintenance nightmare. Now with the artifact system provided by Julia >= 1.3, bundling a default backend into Images looks like a good choice for me. However, we might not want to do this right now because people here are too busy to maintain two Images versions(one for Julia < v1.3 and one for Julia >= v1.3). We can do this when we upgrade to the next Julia LTS version. |
Yes, that was written when FileIO installed packages for you. ImageMagick may be a good choice on Linux, though with ImageIO that's getting less clear. It's even less obviously so on Mac, where QuartzImageIO was at least once the default option. |
Thanks! BTW, I only installed ImageMagick.jl because that's what the error message prompted me to do. |
Just bringing this discussion here. What would we consider the minimum feature set that ImageIO would need to be the one? |
Adding these backends won't increase the loading time of
That said, I think it's would be sufficient to add Adding this requires us to bump Julia compat in I heard rumors that Julia 1.6 will be the next LTS version, if that's the case, then the perfect time is when Julia 1.6 is released. ( I don't feel good to discontinue the support to the current LTS version) |
In the Juliacon 2020 talk "State of Julia 2020", YouTube, it's officially announced that 1.6 will be the next LTS version. We could add |
I use Images.jl only to save a jpg image, using this statement:
using Images
...
save("filename.jpg", someUInt8Matrix)
But my project/enviroment needs ImageMagick to be added before this works. I'm not using it myself directly (I don't have a "using ImageMagick" in my code).
Somewhere Images.jl does use it. I should not have to add "ImageMagick" to my project, it should automatically be added to my Manifest when I Pkg.add Images.
You can replicate by temporarily removing your enviroment, add just Images, and try and use it...
The text was updated successfully, but these errors were encountered: