Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restrict on an AxisArray with non-1 axes #779

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 1, 2019

This may seem like a bit of a rareified combination, but if you're running ImageFiltering 0.5.3+ and OffsetArrays 0.10.0+, you can trigger it on Images master with

using Images, TestImages
img = centered(testimage("mri"))
restrict(img)

I'm a bit unhappy about the implementation of ofaxes (it basically only supports Base and OffsetArrays), but I don't have a better idea ATM.

@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #779 into master will increase coverage by <.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   58.81%   58.81%   +<.01%     
==========================================
  Files          10       10              
  Lines        1231     1236       +5     
==========================================
+ Hits          724      727       +3     
- Misses        507      509       +2
Impacted Files Coverage Δ
src/algorithms.jl 61.27% <81.81%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc31f2c...7b9041a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #779 into master will increase coverage by <.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   58.81%   58.81%   +<.01%     
==========================================
  Files          10       10              
  Lines        1231     1236       +5     
==========================================
+ Hits          724      727       +3     
- Misses        507      509       +2
Impacted Files Coverage Δ
src/algorithms.jl 61.27% <81.81%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc31f2c...7b9041a. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Feb 3, 2019

If someone has better ideas we can always improve this later, so I'll merge this.

@timholy timholy merged commit dd15028 into master Feb 3, 2019
@timholy timholy deleted the teh/restrict_offsetaa branch February 3, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant