support ImageMetadata v0.9.0 #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImageMetadata v0.9.0 deprecates the symbol `data` in favor of `arraydata`, and this would cause a name conflict with ImageAxes when we import both packages. This commit rebinds the deprecation of `data` to `arraydata` and thus fixes this issue. Besides this, this package fixes the depwarn brought by ImageMetadata v0.9.0, and provides backward compatibility to ImageMetadata < v0.9.0 This commit also removes ImageAxes v0.5 from the compat section, it doesn't affect anything because ImageAxes v0.5 isn't compatible to ImageCore v0.8.1 (it's ImageCore = "0.2-0.7" according to the General registry) cf. this commit fixes the broken test in #858
|
I must add a lot of unnecessary tests to the CI with my frequently force-push... just feel free to closes them... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageMetadata v0.9.0 deprecates the symbol
datain favor ofarraydata,and this would cause a name conflict with ImageAxes when we import both
packages. This commit rebinds the deprecation of
datatoarraydataand thusfixes this issue.
Besides this, this package fixes the depwarn brought by ImageMetadata v0.9.0,
and provides backward compatibility to ImageMetadata < v0.9.0
This commit also removes ImageAxes v0.5 from the compat section, it
doesn't affect anything because ImageAxes v0.5 isn't compatible to
ImageCore v0.8.1 (it's ImageCore = "0.2-0.7" according to the General
registry)
cf. this commit fixes the broken test in #858