Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BinaryBuilder to install java?? #136

Open
aviks opened this issue Feb 17, 2021 · 4 comments
Open

Use BinaryBuilder to install java?? #136

aviks opened this issue Feb 17, 2021 · 4 comments

Comments

@aviks
Copy link
Collaborator

aviks commented Feb 17, 2021

Should we try to use BinaryBuilder to install a private version of Java within the Julia depot?

  • Is this a good idea? It's not a terrible idea, many applications do bundle Java. Also, I'm told conda installs it's own Java. But is it a good idea?
  • If we do this, we should probably find a way to re-package the AdoptOpenJDK binaries. Compiling OpenJDK from scratch is certainly not a good idea.
  • If we do this, we should probably use the system installed JVM if the JAVA_HOME environment variable is set.

The main advantage is that the user does not need to install java themselves. This is particularly valuable for users of Julia libraries with Java dependencies. So if you want to use Taro.jl, you don't need to worry about getting a JVM on your machine if you don't already have one.

@mkitti
Copy link
Member

mkitti commented Mar 2, 2021

What are the licensing implications of this?

OpenJDK is GPLv2 with linking exception (classpath exception)

@aviks
Copy link
Collaborator Author

aviks commented Mar 2, 2021

This package is MIT licensed, so it's fine to depend on GPLv2 packages. Most people now use OpenJDK (via AdoptOpenJDK) i imagine.

@mkitti
Copy link
Member

mkitti commented Mar 2, 2021

Yes, but by distributing GPLv2, we will then entering others into a GPLv2 license, and may also draw questions about the licensing of this package, so I think this has be done carefully.

In particular, JavaCall should not depend on a OpenJDK JLL. It should be able to use it is it happens to be installed though.

@mkitti
Copy link
Member

mkitti commented Mar 2, 2021

https:/JuliaMath/FFTW.jl provides some precedent for this, although is some reluctance to distributing the runtimes of other lanugages.

https://julialang.slack.com/archives/C674ELDNX/p1614712811136600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants