Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the Differential Interfaces #429

Closed
wants to merge 21 commits into from

Commits on Sep 24, 2021

  1. Squashed commit of the following:

    commit 26ad8a5
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 20:17:01 2021 +0200
    
        runs formatter.
    
    commit 99bcb23
    Merge: b027f4c 2a03fb1
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 18:33:25 2021 +0200
    
        Merge branch 'master' into kellertuer/polish-diff-interfaces
    
    commit 2a03fb1
    Author: Mateusz Baran <[email protected]>
    Date:   Thu Sep 23 18:08:23 2021 +0200
    
        Support for Zygote and ReverseDiff gradients (#427)
    
        * Support for Zygote and ReverseDiff gradients
    
        * Add Zygote test dependency
    
        * bump ambiguity limit because of Zygote
    
        * fix tests and Zygote backend
    
        * bump Julia to 1.5
    
        * fixing some issues on Julia 1.7-rc1
    
        * more fixing for Julia 1.7
    
        * formatting
    
        * reduce tangent vector length in a test
    
        since the approximation only works very locally (and they changed the default random number generator)
    
        * Update Project.toml
    
        Co-authored-by: Ronny Bergmann <[email protected]>
    
        * bump atol on Rotations
    
        * reduce tangent vector size even further.
    
        * adapt one more tolerance
    
        Co-authored-by: Ronny Bergmann <[email protected]>
    
    commit b027f4c
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 17:11:19 2021 +0200
    
        fix a few typos.
    
    commit dcc471e
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 13:53:07 2021 +0200
    
        unify naming.
    
    commit 3de9a30
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 13:33:59 2021 +0200
    
        Reduce dependencies, wort a little bit further on polishing.
    
    commit 8702902
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 10:45:36 2021 +0200
    
        runs formatter.
    
    commit 378bbba
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 10:45:15 2021 +0200
    
        fix the other jacobian.
    
    commit a7d1edb
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 23 10:29:37 2021 +0200
    
        renaming and dependencies.
    
    commit 02f97d6
    Merge: aca6d5c 9fc772a
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 22 19:48:36 2021 +0200
    
        Merge branch 'master' into kellertuer/polish-diff-interfaces
    
        # Conflicts:
        #	Project.toml
        #	src/Manifolds.jl
    
    commit aca6d5c
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 22 19:46:59 2021 +0200
    
        Add a proper working default.
    
    commit 9fc772a
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 22 19:46:01 2021 +0200
    
        Sketch change metric. (#423)
    
        * Adds a change_metric and a change_representer
        * Apply suggestions from code review
        * bump version.
    
        Co-authored-by: Mateusz Baran <[email protected]>
    
    commit 1462018
    Merge: 923a718 4501a27
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 22 19:20:52 2021 +0200
    
        Merge branch 'kellertuer/gradient-conversion' into kellertuer/polish-diff-interfaces
    
        # Conflicts:
        #	Project.toml
        #	src/differentiation/riemannian_diff.jl
    
    commit 923a718
    Merge: d391483 07c905e
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 22 18:20:39 2021 +0200
    
        Merge branch 'mbaran/reverse-diff-zygote' into kellertuer/polish-diff-interfaces
    
    commit 07c905e
    Author: Mateusz Baran <[email protected]>
    Date:   Wed Sep 22 17:27:10 2021 +0200
    
        Update Project.toml
    
        Co-authored-by: Ronny Bergmann <[email protected]>
    
    commit 4501a27
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 22 17:19:42 2021 +0200
    
        Apply suggestions from code review
    
        Co-authored-by: Mateusz Baran <[email protected]>
    
    commit 3c47350
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 22 08:59:28 2021 +0200
    
        reduce tangent vector length in a test
    
        since the approximation only works very locally (and they changed the default random number generator)
    
    commit 3b7396d
    Author: Mateusz Baran <[email protected]>
    Date:   Tue Sep 21 19:19:09 2021 +0200
    
        formatting
    
    commit 5d75e6e
    Author: Mateusz Baran <[email protected]>
    Date:   Tue Sep 21 19:17:28 2021 +0200
    
        more fixing for Julia 1.7
    
    commit c723345
    Author: Mateusz Baran <[email protected]>
    Date:   Tue Sep 21 12:31:30 2021 +0200
    
        fixing some issues on Julia 1.7-rc1
    
    commit cf00e22
    Author: Mateusz Baran <[email protected]>
    Date:   Tue Sep 21 08:49:40 2021 +0200
    
        bump Julia to 1.5
    
    commit 1ed46db
    Author: Mateusz Baran <[email protected]>
    Date:   Mon Sep 20 23:02:03 2021 +0200
    
        fix tests and Zygote backend
    
    commit 7849fc0
    Author: Mateusz Baran <[email protected]>
    Date:   Mon Sep 20 19:45:41 2021 +0200
    
        bump ambiguity limit because of Zygote
    
    commit 9163480
    Author: Mateusz Baran <[email protected]>
    Date:   Mon Sep 20 14:40:50 2021 +0200
    
        Add Zygote test dependency
    
    commit 7ed57da
    Author: Mateusz Baran <[email protected]>
    Date:   Mon Sep 20 12:48:09 2021 +0200
    
        Support for Zygote and ReverseDiff gradients
    
    commit 2f498da
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 18 23:17:32 2021 +0200
    
        add a test that double metric wrapping is avoided; remove unnecessary dispatch.
    
    commit e180bc4
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 18 21:58:49 2021 +0200
    
        Simplify default implementation. Extend coverage. Order functions alphabetically.
    
    commit 420047d
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 18 20:07:21 2021 +0200
    
        Fix the error message for hyperbolic.
    
    commit ed2871c
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 18 19:54:19 2021 +0200
    
        maybe fix the new test by slightly overtyping the basis.
    
    commit 49dc500
    Author: Ronny Bergmann <[email protected]>
    Date:   Fri Sep 17 18:44:59 2021 +0200
    
        format this interims non-working test.
    
    commit a78ace4
    Author: Ronny Bergmann <[email protected]>
    Date:   Fri Sep 17 18:40:57 2021 +0200
    
        Maybe. just maybe fixed local metric, but now get vector and get coordinates do not work for the test.
    
    commit 97417ae
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 16 14:31:49 2021 +0200
    
        Improve docs.
    
    commit d34ef6c
    Merge: 95a3c8b d1dbb7c
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 16 11:09:24 2021 +0200
    
        Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaManifolds/Manifolds.jl into kellertuer/gradient-conversion
    
    commit 95a3c8b
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 16 11:09:16 2021 +0200
    
        adds a test for positive vectors and starts testing the default Metric fallbacks using the local metric.
    
    commit d1dbb7c
    Author: Ronny Bergmann <[email protected]>
    Date:   Thu Sep 16 10:47:57 2021 +0200
    
        Apply suggestions from code review
    
        Co-authored-by: Mateusz Baran <[email protected]>
    
    commit 14fdb06
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 22:39:38 2021 +0200
    
        bump version.
    
    commit cbcef94
    Merge: da98b5f bd2b425
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 22:38:45 2021 +0200
    
        Merge branch 'master' into kellertuer/gradient-conversion
    
    commit da98b5f
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 22:37:18 2021 +0200
    
        append this step to riemannian differentiation.
    
    commit c154516
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 22:37:01 2021 +0200
    
        finish tests for product and power – extend features to also work on the sphere.
    
    commit 844f8c4
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 21:42:59 2021 +0200
    
        Fixes a few typos in the docs.
    
    commit 5005965
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 20:40:11 2021 +0200
    
        Document and test SPDs
    
    commit d2cec4d
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 20:30:00 2021 +0200
    
        Finish positive Numbers.
    
    commit 7737c92
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 20:03:49 2021 +0200
    
        Extend ProbabilitySimples to also cover change_metric.
    
    commit 6300f80
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 20:03:33 2021 +0200
    
        delete change_representer since it should be inherited from ProbabilitySimplex combined with AbstractPowerManifold and EmbeddedManifold.
    
    commit 95b8bc6
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 19:48:20 2021 +0200
    
        finishes testing for hyperbolic.
    
    commit 6f1fb64
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 19:47:37 2021 +0200
    
        fix a small bug in Hyperbolic copyto! which returned the wrong value.
    
    commit a62e134
    Author: Ronny Bergmann <[email protected]>
    Date:   Wed Sep 15 10:31:24 2021 +0200
    
        Documentation and Test for Poincaré Ball conversion.
    
    commit d84a3cc
    Author: Ronny Bergmann <[email protected]>
    Date:   Tue Sep 14 19:52:52 2021 +0200
    
        adds two further small tests.
    
    commit ea76128
    Author: Ronny Bergmann <[email protected]>
    Date:   Tue Sep 14 19:21:08 2021 +0200
    
        Document and test hyperbolic.
    
    commit 257b223
    Author: Ronny Bergmann <[email protected]>
    Date:   Tue Sep 14 18:20:55 2021 +0200
    
        Finish documentation and test for Generalised Grassmann.
    
    commit 152e9a1
    Author: Ronny Bergmann <[email protected]>
    Date:   Tue Sep 14 18:20:34 2021 +0200
    
        fix transparency of nonmutating to parent on a Manifold level.
    
    commit 1b79065
    Author: Ronny Bergmann <[email protected]>
    Date:   Mon Sep 13 17:49:20 2021 +0200
    
        Fix two typos.
    
    commit 2eac3ee
    Author: Ronny Bergmann <[email protected]>
    Date:   Mon Sep 13 16:30:35 2021 +0200
    
        Change `change_gradient` to `change_represender` and introduce mutating variant
    
    commit 5539f4b
    Author: Ronny Bergmann <[email protected]>
    Date:   Mon Sep 13 12:11:52 2021 +0200
    
        introduce mutating variants and decorator transparency.
    
    commit 714862e
    Merge: 4912e4f 05968dc
    Author: Ronny Bergmann <[email protected]>
    Date:   Sun Sep 12 20:09:17 2021 +0200
    
        Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaManifolds/Manifolds.jl into kellertuer/gradient-conversion
    
    commit 4912e4f
    Author: Ronny Bergmann <[email protected]>
    Date:   Sun Sep 12 20:09:11 2021 +0200
    
        Adress points from code review.
    
    commit 05968dc
    Author: Ronny Bergmann <[email protected]>
    Date:   Sun Sep 12 20:03:18 2021 +0200
    
        Apply suggestions from code review
    
        Co-authored-by: Mateusz Baran <[email protected]>
    
    commit 9769a1a
    Author: Ronny Bergmann <[email protected]>
    Date:   Sun Sep 12 18:17:45 2021 +0200
    
        add the generic case for doubly stochastic (includes symmetric, too).
    
    commit 42875a6
    Author: Ronny Bergmann <[email protected]>
    Date:   Sun Sep 12 18:13:42 2021 +0200
    
        implement the remaining conversions.
    
    commit fb304c2
    Merge: cb2f932 2ee2072
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 16:51:29 2021 +0200
    
        Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaManifolds/Manifolds.jl into kellertuer/gradient-conversion
    
    commit cb2f932
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 16:51:17 2021 +0200
    
        adds a few conversion, where the embedding is not isometric.
    
    commit 2ee2072
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 13:04:01 2021 +0200
    
        Update src/manifolds/MetricManifold.jl
    
        Co-authored-by: Mateusz Baran <[email protected]>
    
    commit c742ea5
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 12:55:35 2021 +0200
    
        Fix two typos.
    
    commit a17b4ca
    Merge: 540f374 056e24c
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 12:47:27 2021 +0200
    
        Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaManifolds/Manifolds.jl into kellertuer/gradient-conversion
    
        # Conflicts:
        #	src/manifolds/MetricManifold.jl
    
    commit 540f374
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 12:46:50 2021 +0200
    
        Specify Reisz representer, change adjoint to ^H.
    
    commit 056e24c
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 12:38:40 2021 +0200
    
        Update src/manifolds/MetricManifold.jl
    
        Co-authored-by: Mateusz Baran <[email protected]>
    
    commit 158bbf2
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 12:33:10 2021 +0200
    
        Apply suggestions from code review
    
        Co-authored-by: Mateusz Baran <[email protected]>
    
    commit 616db5d
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 10:39:47 2021 +0200
    
        Fix a few typos in docs.
    
    commit c9737b3
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 10:21:02 2021 +0200
    
        adds a change_gradient.
    
    commit 0857b21
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 09:25:54 2021 +0200
    
        fix a few typos.
    
    commit a302733
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 09:04:07 2021 +0200
    
        rfF.
    
    commit 3347930
    Author: Ronny Bergmann <[email protected]>
    Date:   Sat Sep 11 09:01:30 2021 +0200
    
        Document insights from yesterday evening and – getting stuck at the next point.
    
    commit ae0cdd1
    Author: Ronny Bergmann <[email protected]>
    Date:   Fri Sep 10 20:38:56 2021 +0200
    
        Sketch change metric.
    kellertuer committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    4376b8b View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into kellertuer/polish-diff-interfaces

    # Conflicts:
    #	Project.toml
    #	src/Manifolds.jl
    #	src/differentiation/differentiation.jl
    #	src/differentiation/finite_diff.jl
    #	src/differentiation/reverse_diff.jl
    #	src/differentiation/riemannian_diff.jl
    #	src/differentiation/zygote.jl
    #	test/differentiation.jl
    kellertuer committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    b2f2674 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. Configuration menu
    Copy the full SHA
    59c0467 View commit details
    Browse the repository at this point in the history
  2. Fixes two typos.

    kellertuer committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    f6bede4 View commit details
    Browse the repository at this point in the history
  3. Fix more typos.

    kellertuer committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    475140e View commit details
    Browse the repository at this point in the history
  4. Move solve_exp_ode with OridnaryDiffEq to differentiation and change …

    …the return value to be just `p`.
    kellertuer committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    61b4dcb View commit details
    Browse the repository at this point in the history
  5. fixes a first test.

    kellertuer committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    49ecd3c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1885973 View commit details
    Browse the repository at this point in the history
  7. trying to improve tests?

    kellertuer committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    2181cff View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Fixes most errors, just some default retractions need to be fixed (st…

    …ill returning ExponentialRetraction).
    kellertuer committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    cde3c8e View commit details
    Browse the repository at this point in the history
  2. reduce errors further.

    kellertuer committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e1bf764 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Configuration menu
    Copy the full SHA
    b112499 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2625fb View commit details
    Browse the repository at this point in the history
  3. fix some tests

    mateuszbaran committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    a6702f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Configuration menu
    Copy the full SHA
    a4a2716 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ed5feb View commit details
    Browse the repository at this point in the history
  3. fixing ode tests a bit

    mateuszbaran committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    d544ce9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    26ab2ec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd39060 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. reorganise to get the ODE stuff (a) defined on arbitrary manifolds an…

    …d (b) into its own test file (away from metric).
    kellertuer committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    44ceb3e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Configuration menu
    Copy the full SHA
    6ac5d75 View commit details
    Browse the repository at this point in the history