Reuse sockets for synchronous calls #14
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some funky stuff going on with exceptions when reusing sockets. The socket probably doesn't flush correctly, causing an error in the next read. The error is not an exception, but an incorrect value. (these can be very strange, like returning the first element of a tuple instead of the whole tuple). Solution: Don't reuse a socket if its corresponding task failed; drop it and create a new one.