Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating Archetype can finish with lost data if notmergable properties are used #236

Open
bielu opened this issue Nov 7, 2023 · 0 comments

Comments

@bielu
Copy link
Contributor

bielu commented Nov 7, 2023

So based on experience in last project, I just found that we missing some type of validation which would check if alias for new block can be match in migrated doctypes.

Example of case:
3 archetypes blocks with same alias, lets be it cta
3 doctypes: HomePage, ContentPage, ArticlePage
configuration as followed:

 "Archetype": {
        "NotMergableDocumentTypes": [
          "cta"
        ],
        "RenamedDocumentTypesAliases": {
          "ctaPaneIHomepagePanels": "ctaHomePage",
          "ctaPanelContentPanels": "ctaContentPage",
          "image": "imagePane",
          "loginArea": "loginAreaPanel",
          "form": "formItem"
        }
      },

the issue is caused by renaming target alias, but we should have some validation in place to throw information in migration log that we have missing target :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant