Skip to content

Commit

Permalink
fix: duration is always zero in PlayerView
Browse files Browse the repository at this point in the history
  • Loading branch information
KRTirtho committed Aug 2, 2023
1 parent 6dff099 commit 4885dca
Showing 1 changed file with 39 additions and 25 deletions.
64 changes: 39 additions & 25 deletions lib/hooks/use_progress.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import 'package:async/async.dart';
import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:spotube/services/audio_player/audio_player.dart';
Expand All @@ -11,47 +12,60 @@ import 'package:spotube/services/audio_player/audio_player.dart';
final bufferProgress =
useStream(audioPlayer.bufferedPositionStream).data?.inSeconds ?? 0;

Duration audioPlayerDuration = Duration.zero;
Duration audioPlayerPosition = Duration.zero;

// Duration future is needed for getting the duration of the song
// as stream can be null when no event occurs (Mostly needed for android)
audioPlayer.duration.then((value) {
if (value != null) {
audioPlayerDuration = value;
}
});

audioPlayer.position.then((value) {
if (value != null) {
audioPlayerPosition = value;
}
});

final position = useState<Duration>(audioPlayerPosition);
final duration =
useStream(audioPlayer.durationStream).data ?? audioPlayerDuration;
final sliderMax = duration.inSeconds;
final duration = useState(Duration.zero);
final position = useState(Duration.zero);

final sliderMax = duration.value.inSeconds;
final sliderValue = position.value.inSeconds;

useEffect(() {
final durationOperation =
CancelableOperation.fromFuture(audioPlayer.duration);
durationOperation.then((value) {
if (value != null) {
duration.value = value;
}
});

final durationSubscription = audioPlayer.durationStream.listen((event) {
duration.value = event;
});

final positionOperation =
CancelableOperation.fromFuture(audioPlayer.position);

positionOperation.then((value) {
if (value != null) {
position.value = value;
}
});

// audioPlayer.positionStream is fired every 200ms and only 1s delay is
// enough. Thus only update the position if the difference is more than 1s
// Reduces CPU usage
var lastPosition = position.value;
return audioPlayer.positionStream.listen((event) {

final positionSubscription = audioPlayer.positionStream.listen((event) {
if (event.inMilliseconds > 1000 &&
event.inMilliseconds - lastPosition.inMilliseconds < 1000) return;

lastPosition = event;
position.value = event;
}).cancel;
}, [audioPlayerPosition, audioPlayerDuration]);
});

return () {
positionOperation.cancel();
positionSubscription.cancel();
durationOperation.cancel();
durationSubscription.cancel();
};
}, []);

return (
progressStatic:
sliderMax == 0 || sliderValue > sliderMax ? 0 : sliderValue / sliderMax,
position: position.value,
duration: duration,
duration: duration.value,
bufferProgress: sliderMax == 0 || bufferProgress > sliderMax
? 0
: bufferProgress / sliderMax,
Expand Down

0 comments on commit 4885dca

Please sign in to comment.