Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Italian language #818

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Added Italian language #818

merged 6 commits into from
Dec 8, 2023

Conversation

energywave
Copy link
Contributor

I've added Italian language as instructed in CONTRIBUTION.md.
I'm not a flutter developer so I tried to install and compile Spotube to test it but it was overkill and I had two errors (the first about app_ar.arb file (not mine), the second about abstract class .env)

Sorry but I decided to open a PR without having tested it. The translation is there and I can check in your compiled dev version if that's all ok or not.
I'm available to check and modify something if needed, just don't have so much time to create a working flutter environment.

@dave9123
Copy link

This indent might be why
image

@energywave
Copy link
Contributor Author

This indent might be why

Oh, by reviewing the file I've noticed that the indentation of my line was made with a tab instead of spaces like other lines. On my editor it was graphically the same so I didn't noticed, thanks to point out.
But does it make any difference to compile? Is Dart something like Python, sensible to indentation?

@dave9123
Copy link

/// credits:
///
/// Kingkor Roy Tirtho => English, Bengali
/// ChatGPT (GPT 3.5) XD => Hindi, French
/// maboroshin@github => Japanese
/// iceyear@github => Simplified Chinese
/// TexturedPolak@github => Polish
/// yuri-val@github => Ukrainian
import 'package:flutter/material.dart';

class L10n {
  static final all = [
    const Locale('en'),
    const Locale('bn', 'BD'),
    const Locale('de', 'GE'),
    const Locale('ca', 'AD'),
    const Locale('es', 'ES'),
    const Locale("fa", "IR"),
    const Locale('fr', 'FR'),
    const Locale('hi', 'IN'),
    const Locale('it', 'IT'),
    const Locale('ja', 'JP'),
    const Locale('zh', 'CN'),
    const Locale('pl', 'PL'),
    const Locale('ru', 'RU'),
    const Locale('pt', 'PT'),
    const Locale('uk', 'UA'),
    const Locale('ar', 'SA'),
  ];
}

@dave9123
Copy link

Copy and paste to l10n.dart

Corrected the wrong TAB in i10n.dart and added translations of new text items
@dave9123
Copy link

On line 22, locale -> Locale
Do you have autocorrect or something by any chance?

Screenshot_2023-10-28-05-49-59-85_320a9a695de7cdce83ed5281148d6f19.jpg

it const name was lowercase
@energywave
Copy link
Contributor Author

On line 22, locale -> Locale Do you have autocorrect or something by any chance?

No, it was me... I had no time and did it quickly. Sorry, now it's fixed.

@OpenCode
Copy link

OpenCode commented Nov 2, 2023

@energywave There is another PR with italian translation: #676
Check it. We discussed some terms there and it might be interesting.

@energywave
Copy link
Contributor Author

@energywave There is another PR with italian translation: #676 Check it. We discussed some terms there and it might be interesting.

Yeah, I've noticed after the creation of my PR :( Damn, I could simply complete that PR instead of reinventing the wheel but I didn't think to search for Italian language open PR... My fault.
It seems that the other PR is not complete and not up to date. So I can process all the discussion on the other PR comments and comply with decisions there so that we can finalize this PR and finally get merged.
We can insert both you and @ncvescera in credits.

@OpenCode
Copy link

OpenCode commented Nov 2, 2023

@energywave There is another PR with italian translation: #676 Check it. We discussed some terms there and it might be interesting.

Yeah, I've noticed after the creation of my PR :( Damn, I could simply complete that PR instead of reinventing the wheel but I didn't think to search for Italian language open PR... My fault. It seems that the other PR is not complete and not up to date. So I can process all the discussion on the other PR comments and comply with decisions there so that we can finalize this PR and finally get merged. We can insert both you and @ncvescera in credits.

I don't care about credits :)
@ncvescera it's on you

@ncvescera
Copy link

Yeah, I've noticed after the creation of my PR :( Damn, I could simply complete that PR instead of reinventing the wheel but I didn't think to search for Italian language open PR... My fault.
It seems that the other PR is not complete and not up to date. So I can process all the discussion on the other PR comments and comply with decisions there so that we can finalize this PR and finally get merged.
We can insert both you and @ncvescera in credits.

If I could continue the work started by me and @OpenCode , it wouldn't be bad.
However, what you're suggesting is fine with me as well.

Added suggestions as in comments of PR KRTirtho#676 and added credits to @ncvescera and @OpenCode
@OpenCode
Copy link

OpenCode commented Dec 6, 2023

@energywave Can you adapt this PR with the terms from the discussion on the other one so we can close it?

@energywave
Copy link
Contributor Author

@energywave Can you adapt this PR with the terms from the discussion on the other one so we can close it?

My commit just before your comment was just what you're asking. I've inserted all the suggestions from the other discussion as stated in the commit title.
From then nothing happened and now the repo is outdated and conflicting. I'll try to update it again but I hope that we can close that PR and integrate the language then.

@energywave
Copy link
Contributor Author

Ok. This PR is synced and ready to merge (I've resolved the merge conflicts that was origintating from the turkish translation).
When you want... :)

@KRTirtho
Copy link
Owner

KRTirtho commented Dec 8, 2023

Great work everyone and also @ncvescera.

@KRTirtho KRTirtho merged commit e4eb0e2 into KRTirtho:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants