Updated/created script for handling prerequisites #268
Conversation
axelbjo
requested review from
belanglos,
karlandindrakryggen,
amirhossein-haerian and
allazis
as code owners
package.json
Outdated
| @@ -26,6 +26,7 @@ | |||
| "@kth/server": "^4.1.0", | |||
| "body-parser": "^1.20.2", | |||
| "cookie-parser": "^1.4.6", | |||
| "csv-parser": "^3.0.0", | |||
There was a problem hiding this comment.
This should not be check-in as its not used by the application itself. We just need to install in locally we run the import script.
scripts/importData/database.js
Outdated
| @@ -1,5 +1,8 @@ | |||
| const log = require('@kth/log') | |||
| const nodeMongo = require('@kth/mongo') | |||
| const dotenv = require('dotenv') | |||
There was a problem hiding this comment.
I guess this was part of the confusion when I tried it as well as this wasn't part of the other PR. In the script Benni created he used the --env param to node to load a specific env-fil, and --env needs node 20.
I like Benni approach with a separate .env-file and use of --env since it will be super clear which env-file that is used, and it will be less likely that you make a misstake to use wrong mongo db instance.
What do you think? We can discuss this further tomorrow.
There was a problem hiding this comment.
Yes, now I think I remember that the reason for why I added this was because I got the connection string error as well when I tried to connect to my local db, but I think that Benni's approach sounds better! I'll be happy to discuss it tomorrow to understand it a bit better as well.
scripts/importData/index3.js
Outdated
There was a problem hiding this comment.
I think it would be good to add a *.sh script similar to scripts/importSupplementaryInfo.sh and add a section about that in the README (scripts/importData/README.md) as well, so that it is the same as the old scripts.
No description provided.