Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow for successful new ride addition #25

Open
dipanshu231099 opened this issue Jan 2, 2022 · 7 comments · May be fixed by #28
Open

Flow for successful new ride addition #25

dipanshu231099 opened this issue Jan 2, 2022 · 7 comments · May be fixed by #28
Assignees
Labels

Comments

@dipanshu231099
Copy link
Collaborator

Currently, the user adds a new ride and it creates a new Pool object which is stored in DB. However the user doesn't fetch any confirmation that his/her submission was successful or not. Redirect the user to the home page, and showcase a temporary alert mentioning that the submission was successful.

@dipanshu231099 dipanshu231099 added enhancement New feature or request good first issue Good for newcomers functionality and removed enhancement New feature or request labels Jan 2, 2022
@UjjawalKhadanga
Copy link

@dipanshu231099 I would like to work on this issue. Please assign me this task.

@dipanshu231099
Copy link
Collaborator Author

@UjjawalKhadanga please mention your working / link your PR if you are still working or have submitted the PR

@dipanshu231099
Copy link
Collaborator Author

@UjjawalKhadanga this is not showing errors. Even when there is an error to submit the new ride, the message is shown for added successfully. Please fix the PR

@UjjawalKhadanga
Copy link

@dipanshu231099 Can you tell what kind of errors are possible and how to generate them?

@dipanshu231099
Copy link
Collaborator Author

@UjjawalKhadanga try of thinking all possible cases. Try to create some edge cases. Your code should work correctly for these cases.

@UjjawalKhadanga
Copy link

@dipanshu231099 please review my code #28

@Payalsahb20220
Copy link

@dipanshu231099 sir , I resolve this query.
please look on my code that if it working properly or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment