Fix asm-offset headers (re)generation; Generate binary with debug symbols #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
added
cleanup
bugfix
minipli-oss
requested changes
Nov 13, 2023
Use explicit path for the to-be-generated header files, so make can make a timestamp comparison and not regenerate the headers every time. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Instead of generating a final binary with debug symbols and stripping them out to additional file, just copy the final binary to the final target destination (kernel64.bin) and strip the file. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
sktt
previously approved these changes
Nov 13, 2023
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.