Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for KHR_animation_pointer #198

Open
hybridherbst opened this issue Oct 19, 2022 · 5 comments
Open

Support for KHR_animation_pointer #198

hybridherbst opened this issue Oct 19, 2022 · 5 comments

Comments

@hybridherbst
Copy link

While Gestaltor, Babylon and Needle Engine (based on three.js) have already implemented KHR_animation_pointer, the validator currently doesn't support it. That leads to thousands and sometimes hundreds of thousands of errors for files that work fine:
image

The errors are many times

           {
                "code": "VALUE_NOT_IN_LIST",
                "message": "Invalid value 'pointer'. Valid values are ('translation', 'rotation', 'scale', 'weights').",
                "severity": 1,
                "pointer": "/animations/0/channels/2/target/path"
            },

and

            {
                "code": "ANIMATION_DUPLICATE_TARGETS",
                "message": "Animation channel has the same target as channel 353.",
                "severity": 0,
                "pointer": "/animations/2/channels/9/target"
            },

Are there plans / what are the plans for supporting KHR_animation_pointer to ensure files are correctly set up? I understand that this is kind of a chicken-and-egg situation between the extension not being ratified (yet) and the need to produce correct files for it, but wanted to ask nonetheless :)

Thanks!

@lexaknyazev
Copy link
Member

The ANIMATION_DUPLICATE_TARGETS error was suppressed in the recent release. Babylon (that's on the screenshot) uses an old version.

The VALUE_NOT_IN_LIST warning will remain until the extension is fully implemented.

@hybridherbst
Copy link
Author

Thanks - in which one was it suppressed? I copied the above from the output of https://github.khronos.org/glTF-Validator/ yesterday.

@lexaknyazev
Copy link
Member

The hosted version is also a bit old, I'll handle that shortly.

@bghgary
Copy link

bghgary commented Oct 27, 2022

FYI, I updated the glTF validator in Babylon.js sandbox. Many of the errors went away, but there are still a couple of errors and a bunch of warnings.

https://sandbox.babylonjs.com/?assetUrl=https://raw.githubusercontent.com/KhronosGroup/glTF-Sample-Models/e2609a847ef508c8bc8308982bb6534581c94f7f/2.0/AnimationPointer/AnimateAllTheThings/glTF/AnimateAllTheThings.gltf

{
  "uri": "https://raw.githubusercontent.com/KhronosGroup/glTF-Sample-Models/e2609a847ef508c8bc8308982bb6534581c94f7f/2.0/AnimationPointer/AnimateAllTheThings/glTF/AnimateAllTheThings.gltf",
  "mimeType": "model/gltf+json",
  "validatorVersion": "2.0.0-dev.3.9",
  "validatedAt": "2022-10-27T20:26:25.531Z",
  "issues": {
    "numErrors": 2,
    "numWarnings": 69,
    "numInfos": 36,
    "numHints": 0,
    "messages": [
      {
        "code": "UNSUPPORTED_EXTENSION",
        "message": "Cannot validate an extension as it is not supported by the validator: 'KHR_animation_pointer'.",
        "severity": 2,
        "pointer": "/extensionsUsed/6"
      },
      {
        "code": "VALUE_NOT_IN_LIST",
        "message": "Invalid value 'pointer'. Valid values are ('translation', 'rotation', 'scale', 'weights').",
        "severity": 1,
        "pointer": "/animations/0/channels/0/target/path"
      },
      {
        "code": "VALUE_NOT_IN_LIST",
        "message": "Invalid value 'pointer'. Valid values are ('translation', 'rotation', 'scale', 'weights').",
        "severity": 1,
        "pointer": "/animations/0/channels/1/target/path"
      },
      {
        "code": "VALUE_NOT_IN_LIST",
        "message": "Invalid value 'pointer'. Valid values are ('translation', 'rotation', 'scale', 'weights').",
        "severity": 1,
        "pointer": "/animations/0/channels/2/target/path"
      },
      {
        "code": "VALUE_NOT_IN_LIST",
        "message": "Invalid value 'pointer'. Valid values are ('translation', 'rotation', 'scale', 'weights').",
        "severity": 1,
        "pointer": "/animations/0/channels/3/target/path"
      },
      {
        "code": "VALUE_NOT_IN_LIST",
        "message": "Invalid value 'pointer'. Valid values are ('translation', 'rotation', 'scale', 'weights').",
        "severity": 1,
        "pointer": "/animations/0/channels/4/target/path"
      },

@julienduroure
Copy link

Hello,
KHR_animation_pointer is now officially ratified, but seems the validator still doesn't manage it

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants