Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable panic_on_warn=1 #268

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

raja-grewal
Copy link
Contributor

Partial follow-up on #264 (comment).

This pull request sets sysctl kernel.panic_on_warn=1 as per the KSPP recommendations.

# Reboot after even 1 WARN or BUG/Oops. Adjust for your tolerances. (Since v6.2)
# If you want to set oops_limit greater than one, you will need to disable CONFIG_PANIC_ON_OOPS.
kernel.warn_limit = 1
kernel.oops_limit = 1

The proposed setting is not exactly equivalent as the KSPP assumes kernel >= 6.2. Therefore, we are forced to use the older binary kernel.panic_on_warn=1 enabling which does not allow setting numerical limits.

Could potentially still enable forcing reboot after a single kernel panic using kernel.panic=-1 to be in full compliance with the KSPP. Thoughts?

Changes

Set sysctl kernel.panic_on_warn=1.

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@adrelanos
Copy link
Member

Could you please undo this in https:/Kicksecure/debug-misc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants