Remove byteorder dependency #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
force-pushed
the
remove-byteorder-dep
branch
from
4c10794
to
7171ea6
Compare
In doing so, simplify bit_reader_reverse::refill_slow a tad.
workingjubilee
force-pushed
the
remove-byteorder-dep
branch
from
7171ea6
to
74a378e
Compare
workingjubilee
commented
Aug 25, 2024
Comment on lines
+68
to
+70
| let offset @ 1..=8 = can_read_bytes as usize else { | ||
| unreachable!() | ||
| }; |
There was a problem hiding this comment.
If you would prefer to maintain the "evening out" that the code previously did (i.e. 6..=7 => 6 and so on), that can be done, but both versions pass a cargo test, and if there's a material reason that one shouldn't, then a test should exist that prevents regressing this.
Merged
|
Fuzzing is seemingly not finding new issues with this variant. ( Still not on Aug 29 ) |
|
I'm guessing this is obsolete with #67 containing these changes too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doing so, simplify bit_reader_reverse::refill_slow a tad.
The primary reason for doing this is to make the std/backtrace integration step with this crate easier. This way we have one less dependency to compile, and thus don't have to also "bless" byteorder with the special features libstd needs to compile a crate as part of its dependencies.