Fix Kuma more and release 2.10.2 #623
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Kuma's annotation for specifying a ServiceAccount token manually. This allows Kuma to run on releases that lack a controller container (and therefore have no container with an existing token for Kuma to detect and mount).
shaneutt
approved these changes
Jun 29, 2022
|
Thanks travis 🤜🤛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Yet more fixes for #620, to address the case where there's no controller container (split/standalone instances and hybrid data planes) and Kuma cannot automatically determine the Secret based on the existing mount in the controller container.
Release 2.10.2.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
This annotation is actually scheduled for deprecation in favor of ContainerPatch, but that won't work for this yet. IMO we should just keep the annotation, but that's up to the Kuma devs.
My original attempt to use ContainerPatch, which works as long as you don't have other Kuma container mounts, is
containerpatch.diff.txt
Manual validation:
testing.txt
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.