Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): add namespaceSelector from values #794

Merged
merged 3 commits into from
May 11, 2023

Conversation

mcharriere
Copy link
Contributor

@mcharriere mcharriere commented May 11, 2023

What this PR does / why we need it:

This PR adds the possibility of customizing the ValidatingWebhookConfiguration's namespaceSelector.
The idea is that by adding something like this as values, one could ignore validation for certain namespaces.

ingressController:
  admissionWebhook:
    namespaceSelector:
      matchExpressions:
      - key: kubernetes.io/metadata.name
        operator: NotIn
        values:
        - cert-manager

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@mcharriere mcharriere requested a review from a team as a code owner May 11, 2023 09:04
Signed-off-by: Matias Charriere <[email protected]>
charts/kong/README.md Outdated Show resolved Hide resolved
@pmalek pmalek added the enhancement New feature or request label May 11, 2023
Signed-off-by: Matias Charriere <[email protected]>
@pmalek pmalek merged commit c378aa9 into Kong:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants