Fix & Update: file linting: Adds support for extends keyword and upgrades vacuum lib #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rspurgeon
commented
Apr 10, 2024
•
rspurgeon
commented
- Adds better support for linting OAS in addition to existing deck file linting.
- Upgrades the vacuum dependency to 0.9.11
- Adds more linting integration tests
rspurgeon
commented
Apr 10, 2024
rspurgeon
changed the title
rspurgeon
force-pushed
the
lint-fix-add-oas
branch
from
010c62f
to
76c4399
Compare
mheap
previously approved these changes
Apr 12, 2024
Tieske
reviewed
Apr 15, 2024
cmd/file_lint.go
Outdated
Comment on lines
69
to
72
| err := json.Unmarshal(fileBytes, &contents) | ||
| if err != nil { | ||
| err = yaml.Unmarshal(fileBytes, &contents) | ||
| } |
There was a problem hiding this comment.
you can just use a YAML decoder, since JSON is also valid YAML.
Tieske
approved these changes
Apr 15, 2024
|
@rspurgeon FYI: the CI of this PR was failing due to a race condition in the vacuum lib. I'm now skipping the lint tests since upgrading the dependency doesn't seem to help: #1275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.