Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not fetch oauth2 from konnect #128

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix: do not fetch oauth2 from konnect #128

merged 2 commits into from
Aug 16, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Aug 16, 2024

Summary

As Konnect does not support OAuth2 credentials, we should not try to fetch them when dumping config (currently it returns 404s that are ignored).

Issues resolved

Part of Kong/kubernetes-ingress-controller#6240.

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

@czeslavo czeslavo self-assigned this Aug 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 42.72%. Comparing base (8de497a) to head (7e362ad).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/dump/dump.go 0.00% 7 Missing ⚠️
pkg/utils/types.go 0.00% 4 Missing ⚠️
pkg/file/writer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   42.72%   42.72%   -0.01%     
==========================================
  Files          75       75              
  Lines        8819     8820       +1     
==========================================
  Hits         3768     3768              
- Misses       4587     4588       +1     
  Partials      464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo requested a review from a team August 16, 2024 15:10
@czeslavo czeslavo merged commit 51de016 into main Aug 16, 2024
44 checks passed
@czeslavo czeslavo deleted the fix/konnect-oauth2 branch August 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants