Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(diff+file): avoid filling defaults in config for kong #133

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix(diff+file): avoid filling defaults in config for kong #133

merged 2 commits into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. fix(diff+file): avoid filling defaults in config for kong 

    the previous logic was filling defaults in the configuration that was
passed to Kong. This was  problematic, especially where nils were
populated as defaults, e.g. if a shorthand_field was passed with some
value and the corresponding new field is auto-populated as `nil` by decK
, the auto-populated nil value would take precedence in Kong thus causing
the shorthand_field to be ignored
(https://konghq.atlassian.net/browse/KAG-5157).

This change applies the default values only to configurations used for
diff, the original configuration is always passed to Kong as is.
    @samugi
    samugi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    592369a View commit details
    Browse the repository at this point in the history

  2. Test/avoid filling defaults in config for kong (#135) 

    * add tests for plugin filling default values

---------

Co-authored-by: samugi <[email protected]>
    @randmonkey @samugi
    randmonkey and samugi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    decf4d3 View commit details
    Browse the repository at this point in the history