Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIC 2.0 - Integration Testing - Cleanup Our Controller Runner #1128

Closed
2 tasks
shaneutt opened this issue Mar 24, 2021 · 2 comments
Closed
2 tasks

KIC 2.0 - Integration Testing - Cleanup Our Controller Runner #1128

shaneutt opened this issue Mar 24, 2021 · 2 comments
Assignees
@mflendrich
Labels
area/ci area/debt priority/medium

Comments

@shaneutt
Copy link
Contributor

shaneutt commented Mar 24, 2021 •
edited
Loading

A hack was introduced in our KIC 2.0 Integration Tests to run the controller-manager as an exec.Command, where in the future we should be able to run this as a library in goroutines and shut it down cleanly in the suite_test.go.

Acceptance Criteria:

  • run our controller manager via goroutine
  • enable test coverage for the controller manager in the integration tests
@shaneutt shaneutt mentioned this issue Mar 24, 2021
Merged
@shaneutt shaneutt mentioned this issue Mar 29, 2021
Merged
@mflendrich mflendrich removed the pinned label Mar 31, 2021
@shaneutt shaneutt mentioned this issue Apr 8, 2021
Merged
@mflendrich
Copy link
Contributor

#1175 attempts at making the controller manager runnable as a function

@shaneutt
Copy link
Contributor Author

#1175 took care of this 🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mflendrich mflendrich

Labels
area/ci area/debt priority/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mflendrich @shaneutt