Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the /config timeout configurable #1291

Closed
mflendrich opened this issue May 10, 2021 · 3 comments · Fixed by #1401
Closed

Make the /config timeout configurable #1291

mflendrich opened this issue May 10, 2021 · 3 comments · Fixed by #1401
Assignees
@tharun208
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. onboarding priority/low size/small
Milestone
Blockers for cutt...

Comments

@mflendrich
Copy link
Contributor

Implement a flag to control the setting below.

kubernetes-ingress-controller/railgun/internal/proxy/clientgo_cached_proxy_resolver.go

Line 214 in 347ed5f

timedCtx, cancel := context.WithTimeout(p.ctx, 10*time.Second)

@shaneutt shaneutt added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. onboarding priority/low size/small labels Jun 2, 2021
@tharun208
Copy link
Contributor

@shaneutt I like to work on this

@shaneutt
Copy link
Contributor

shaneutt commented Jun 7, 2021

@shaneutt I like to work on this

Sounds good, freel free and thank you 🙇

@tharun208 tharun208 mentioned this issue Jun 7, 2021
Merged
1 task
@tharun208
Copy link
Contributor

implemented in #1401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tharun208 tharun208

Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. onboarding priority/low size/small
Projects
None yet
Milestone
Blockers for cutting KIC 2.0-beta.1
Development

Successfully merging a pull request may close this issue.

feat(config) make timeout configurable for the kong client
3 participants
@mflendrich @shaneutt @tharun208