Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIC 2.0: handle update-status and update-status-on-shutdown flags #1304

Closed
rainest opened this issue May 11, 2021 · 2 comments · Fixed by #1514
Closed

KIC 2.0: handle update-status and update-status-on-shutdown flags #1304

rainest opened this issue May 11, 2021 · 2 comments · Fixed by #1514
Assignees
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. onboarding priority/low size/small

Comments

@rainest
Copy link
Contributor

rainest commented May 11, 2021

--update-status enables or disables the Ingress status update background job.

--update-status-on-shutdown enables or disables Ingress status updates by the leader when it is shutting down. It is enabled by default. The 1.x implementation had known issues.

In 1.x, these updates populate address information for Ingress objects (i.e. the value shown in the ADDRESS column when you run kubectl get ingress). 2.x reworks status handling significantly.

Low priority since toggling status updates off isn't a critical feature.

@shaneutt shaneutt added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. onboarding size/small labels Jun 2, 2021
@shaneutt shaneutt self-assigned this Jul 8, 2021
@shaneutt
Copy link
Contributor

shaneutt commented Jul 8, 2021

I have re-enabled --update-status but I can see no value in maintaining the --update-status-on-shutdown. KIC 2.0 has no other mechanisms for cleanup on shutdown, and in fact the re-entrant nature of the current design is meant to account for "cleanup". As such I have made a PR which proposes deprecating the second flag given that it conflicts with the direction we're going with KIC, and seems to be of dubious value (whereas conversely --update-status is of obvious value).

@shaneutt shaneutt linked a pull request Jul 8, 2021 that will close this issue
1 task
@shaneutt shaneutt closed this as completed Jul 9, 2021
@sephethus
Copy link

That's fine, nobody knows where to put that flag anyway because it's not like there's examples or documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. onboarding priority/low size/small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants