Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combine coverage and CI workflow #1672

Merged
merged 1 commit into from
Aug 6, 2021
Merged

fix: combine coverage and CI workflow #1672

merged 1 commit into from
Aug 6, 2021

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Aug 5, 2021

What this PR does / why we need it:

Our codecov integration is noisy and gets multiple profiles at different times, causing it to drop multiple messages on PRs.

Additionally, we want to be able to capture coverage output from multiple different test types (unit, integration, e.t.c.)

This PR fixes these problems by having each test target in the Makefile provide it's own coverage profile, and adds a CI workflow which will wait for all tests to finish before combining them and uploading them to codecov.

Additionally this enables the use of our codecov API token instead of doing anonymous updates.

@shaneutt shaneutt added area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Aug 5, 2021
@shaneutt shaneutt self-assigned this Aug 5, 2021
@shaneutt shaneutt marked this pull request as ready for review August 5, 2021 22:53
@shaneutt shaneutt requested a review from a team as a code owner August 5, 2021 22:53
@shaneutt shaneutt marked this pull request as draft August 5, 2021 22:54
@shaneutt shaneutt force-pushed the combine-coverage branch 2 times, most recently from 7e84259 to e3a1178 Compare August 5, 2021 23:00
@shaneutt shaneutt marked this pull request as ready for review August 5, 2021 23:11
@shaneutt shaneutt enabled auto-merge (squash) August 5, 2021 23:11
@shaneutt shaneutt temporarily deployed to Configure ci August 5, 2021 23:18 Inactive
@shaneutt shaneutt merged commit 3971a5b into next Aug 6, 2021
@shaneutt shaneutt deleted the combine-coverage branch August 6, 2021 00:22
@mflendrich
Copy link
Contributor

The coverage CI run on this PR had a silent failure that we missed:

[2021-08-05T23:19:08.024Z] ['error'] There was an error reading the coverage file: Error: EISDIR: illegal operation on a directory, read
[2021-08-05T23:19:08.024Z] ['error'] There was an error reading the coverage file: Error: EISDIR: illegal operation on a directory, read
[2021-08-05T23:19:08.024Z] ['error'] There was an error reading the coverage file: Error: EISDIR: illegal operation on a directory, read

Reported #1699 following Travis's slack report and fixing this in #1700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. ci/license/unchanged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants