Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway APIs Milestone 1 - Validating Webhook #1946

Closed
5 tasks done
shaneutt opened this issue Oct 20, 2021 · 0 comments · Fixed by #2047
Closed
5 tasks done

Gateway APIs Milestone 1 - Validating Webhook #1946

shaneutt opened this issue Oct 20, 2021 · 0 comments · Fixed by #2047
Assignees
@shaneutt
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API priority/medium waiting-on-pr-review This work is on-hold, specifically because no further work can be done until review is complete
Milestone
Gateway API - Mil...

Comments

@shaneutt
Copy link
Contributor

shaneutt commented Oct 20, 2021 •
edited
Loading

Feature

The purpose of this issue is to implement API validation for Gateway resources Gateway API, and particularly add validation for verify that only "existing gateway mode" is in use to provide clear failures and errors for unsupported provisioning options.

Proposed Solution

  • add a new validator for Gateway in our validating webhooks
  • add creation validation that rejects Kong Gateways which are not configured for existing Gateway mode
  • add integration tests for the validators

Prerequisites

Acceptance Criteria

  • as an end-user I should get a clear failure and error message if I post a Gateway with unsupported options, rather than having to find the problems in controller logs later
@shaneutt shaneutt added priority/medium area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API labels Oct 20, 2021
@shaneutt shaneutt added this to the Gateway API - Milestone 1 milestone Oct 20, 2021
@shaneutt shaneutt self-assigned this Nov 30, 2021
@shaneutt shaneutt mentioned this issue Dec 2, 2021
Merged
1 task
@shaneutt shaneutt added the waiting-on-pr-review This work is on-hold, specifically because no further work can be done until review is complete label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaneutt shaneutt

Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API priority/medium waiting-on-pr-review This work is on-hold, specifically because no further work can be done until review is complete
Projects
None yet
Milestone
Gateway API - Milestone 1
Development

Successfully merging a pull request may close this issue.

feat: gateway object validation Kong/kubernetes-ingress-controller
1 participant
@shaneutt