Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use networking.knative.dev/ingress-class additionally to networking.knative.dev/ingress.class #2485

Merged
merged 7 commits into from
May 17, 2022
Merged

chore: use networking.knative.dev/ingress-class additionally to networking.knative.dev/ingress.class #2485

merged 7 commits into from
May 17, 2022

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented May 12, 2022 •
edited
Loading

What this PR does / why we need it:

Use networking.knative.dev/ingress-class as well as networking.knative.dev/ingress-class annotations (with the priority on the former - added in this PR) since knative has already added support for networking.knative.dev/ingress-class in knative/networking#522

Which issue this PR fixes :

fixes #2344

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 07:28 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 07:28 Inactive
@pmalek pmalek changed the title chore: rename ingress.class to ingress-class chore: rename kubernetes.io/ingress.class to kubernetes.io/ingress-class May 12, 2022
@CLAassistant
Copy link

CLAassistant commented May 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pmalek pmalek changed the title chore: rename kubernetes.io/ingress.class to kubernetes.io/ingress-class chore: rename kubernetes.io/ingress.class to kubernetes.io/ingress-class May 12, 2022
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 07:30 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 07:30 Inactive
@pmalek pmalek self-assigned this May 12, 2022
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 07:50 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 07:50 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 08:10 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 08:51 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 08:51 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 08:52 Inactive
@pmalek pmalek changed the title chore: rename kubernetes.io/ingress.class to kubernetes.io/ingress-class chore: use ingress.class instead of ingress-class with knative May 12, 2022
@pmalek pmalek changed the title chore: use ingress.class instead of ingress-class with knative chore: use ingress-class instead of ingress.class with knative May 12, 2022
@pmalek pmalek temporarily deployed to Configure ci May 12, 2022 09:21 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 16, 2022 14:22 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 16, 2022 14:22 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 16, 2022 14:46 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 09:58 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 09:59 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 11:30 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 11:32 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 11:32 Inactive
@pmalek pmalek requested a review from mflendrich May 17, 2022 11:32
@pmalek pmalek marked this pull request as ready for review May 17, 2022 11:32
@pmalek pmalek requested a review from a team as a code owner May 17, 2022 11:32
@pmalek pmalek mentioned this pull request May 17, 2022
Closed
1 task
mflendrich
mflendrich reviewed May 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pmalek @mflendrich
Update CHANGELOG.md
29b7d01 
Co-authored-by: Michał Flendrich <[email protected]>
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 11:48 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 11:49 Inactive
@mflendrich mflendrich enabled auto-merge (squash) May 17, 2022 11:55
mflendrich
mflendrich previously approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 12:11 Inactive
@pmalek pmalek disabled auto-merge May 17, 2022 12:11
@pmalek pmalek enabled auto-merge (squash) May 17, 2022 12:12
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 12:29 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 12:29 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 13:17 Inactive
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 13:17 Inactive
@pmalek pmalek disabled auto-merge May 17, 2022 13:21
@pmalek pmalek temporarily deployed to Configure ci May 17, 2022 13:38 Inactive
@pmalek pmalek requested a review from shaneutt May 17, 2022 14:06
@pmalek pmalek merged commit a1e696e into main May 17, 2022
@pmalek pmalek deleted the ingress-class-rename branch May 17, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflendrich mflendrich mflendrich approved these changes

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@pmalek pmalek

Labels
area/knative
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ingress-class instead of ingress.class for Knative Ingress
3 participants
@pmalek @CLAassistant @mflendrich