fix: ensure connectivity with Kubernetes API on start-up #4641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It introduces a Kubernetes API status check on start-up to prevent issues like #4603 and #4207. With the connectivity ensured, we may rely on controller-runtime default behavior (cache sync timeout will be triggered in case of missing CRDs) and drop our manual checks for Kong's CRD existence.
Adds envtests:
TestManagerDoesntStartUntilKubernetesAPIReachable
to ensure the manager will not start its runnables (including the config sync loop) until the Kubernetes API is reachable.TestNoKongCRDsInstalledIsFatal
to ensure that in case of missing Kong CRDs installation, the controller will eventually crash.TestGatewayAPIControllersMayBeDynamicallyStarted
to ensure Gateway API CRDs can be installed during the runtime and their controllers will be started dynamically in such a case.Also, migrates Knative Ingress controller to use
DynamicCRCController
just to not maintain 3 ways of initializing the controllers.Which issue this PR fixes:
Should fix #4603 and #4207.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR