-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise CRD code markers/validations #5105
Comments
@pmalek Please check if there are nothing in the current webhook that can be moved to CRD annotations. If there is anything to do, please move it to milestone 3.4, otherwise close it. |
Just did a spot check and I don't see anything obvious that could be moved to CEL/code markers. Most of what we do in KIC's admission webhook these days is either cross object validation or validating against Gateway schema, neither of which can be done in CEL/code markers. Closing. |
Problem statement
#5103 tries to solve #5061 but leaves the CRD validations unreviewed.
For instance:
KongConsumer
'sUsername
is required (enforced in admission webhook) but that could easily be changed to a required field on the CRD level via:This unfortunately can only be done when the
// +kubebuilder:validation:Optional
is removed from the package as that overrides the field level setting.Acceptance criteria
main
The text was updated successfully, but these errors were encountered: