-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile all secret with label konghq.com/credential #5398
Comments
it should help also for #5175 |
Thanks for reporting this issue. #5816 should fix this. |
@piotrwielgolaski-tomtom do you know what's actually causing the reconcile by reference to fail and require a second pass? Offhand I'd expect that approach should work, since we shouldn't need Secrets with no references. tl;dr from #5816 (review) do you observe this specifically when creating a KongConsumer and its Secret at the same time (so we aren't necessarily aware of the reference at Secret creation time), or does it happen consistently regardless? I think we'll probably just go with the simpler approach of ingesting all credentials unless we find we need tighter bound, but it'd be useful to understand the exact nature of this problem should we need to re-introduce reference-based ingest in the future. |
#5819 was created to track the enhancement of not storing all the |
Is there an existing issue for this?
Problem Statement
When configuration is build controller ignores all secret until it find reference in any consumer
which leads to invalid/incomplete configuration (it must wait for another reconcile cycle - default 2min)
Proposed Solution
konghq.com/credential
inkubernetes-ingress-controller/internal/controllers/configuration/secret_controller.go
Line 90 in e154f20
Additional information
This will populate store with all secret that may be used by consumers
Idea in code
Acceptance Criteria
No response
The text was updated successfully, but these errors were encountered: