Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test: replace sleep with a closed-loop mechanism #941

Closed
mflendrich opened this issue Nov 2, 2020 · 2 comments
Closed

E2E test: replace sleep with a closed-loop mechanism #941

mflendrich opened this issue Nov 2, 2020 · 2 comments
Labels
area/debt area/tests needs investigation stale Will be closed unless advocated for within 7 days

Comments

@mflendrich
Copy link
Contributor

Today, our E2E test cases work the following way:

  1. apply KIC-readable manfiests to Kubernetes
  2. wait for KIC to apply config to Kong proxy
  3. assert

Step 2 is implemented as sleep 6 today because there's no obvious way to tell that Kong is ready to proxy traffic using up-to-date configuration.

The scope of this issue is to replace sleep with a mechanism that is aware of Kong proxy's successful application of configuration.

@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Will be closed unless advocated for within 7 days label Mar 20, 2021
@stale stale bot closed this as completed Mar 27, 2021
@mflendrich
Copy link
Contributor Author

No longer a problem since #1040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/debt area/tests needs investigation stale Will be closed unless advocated for within 7 days
Projects
None yet
Development

No branches or pull requests

1 participant