Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move library packages from internal/ to pkg/ #1027

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Conversation

mflendrich
Copy link
Contributor

@mflendrich mflendrich commented Feb 3, 2021

This PR moves the following packages:

internal/ingress/controller/parser/kongstate -> pkg/kongstate
internal/ingress/controller/parser -> pkg/parser
internal/ingress/controller/util AND internal/ingress/utils -> pkg/util (merged)
internal/ingress/controller/store -> pkg/store
internal/ingress/annotations -> pkg/annotations

in order to allow for use of KIC's logic (that's not tightly coupled with the controller loop) as a library from an external source (specifically: in an experimental new implementation of the controller).

If the change looks good, it needs to be merged ASAP (and ported to next even ASAPer) because it will cause merge conflicts in all work in flight.

Future work: decouple Kong updating logic from type KongController in internal/ingress/controller.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1027 (849cc50) into main (f69ea6f) will not change coverage.
The diff coverage is 36.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1027   +/-   ##
=======================================
  Coverage   49.65%   49.65%           
=======================================
  Files          32       32           
  Lines        3198     3198           
=======================================
  Hits         1588     1588           
  Misses       1481     1481           
  Partials      129      129           
Impacted Files Coverage Δ
cli/ingress-controller/flags.go 96.25% <ø> (ø)
cli/ingress-controller/main.go 0.23% <0.00%> (ø)
internal/ingress/controller/controller.go 0.00% <ø> (ø)
internal/ingress/controller/kong.go 6.66% <0.00%> (ø)
pkg/annotations/annotations.go 88.88% <ø> (ø)
pkg/kongstate/consumer.go 75.00% <ø> (ø)
pkg/kongstate/kongstate.go 20.49% <ø> (ø)
pkg/kongstate/route.go 90.32% <ø> (ø)
pkg/kongstate/service.go 80.00% <ø> (ø)
pkg/kongstate/types.go 0.00% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69ea6f...849cc50. Read the comment docs.

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shaneutt shaneutt merged commit f9d44c6 into main Feb 3, 2021
@shaneutt shaneutt deleted the chore/move-pkg branch February 3, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants