Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kic 2.0) support selector tags #1415

Merged
merged 6 commits into from
Jul 1, 2021
Merged

feat(kic 2.0) support selector tags #1415

merged 6 commits into from
Jul 1, 2021

Conversation

tharun208
Copy link
Contributor

@tharun208 tharun208 commented Jun 10, 2021

Signed-off-by: Tharun [email protected]

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1292

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@tharun208 tharun208 requested a review from a team as a code owner June 10, 2021 19:41
@tharun208 tharun208 changed the base branch from main to next June 11, 2021 04:38
railgun/manager/run.go Outdated Show resolved Hide resolved
pkg/sendconfig/sendconfig_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1415 (9699c70) into next (4e1f61a) will decrease coverage by 2.50%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1415      +/-   ##
==========================================
- Coverage   55.79%   53.29%   -2.51%     
==========================================
  Files          44       47       +3     
  Lines        3733     3916     +183     
==========================================
+ Hits         2083     2087       +4     
- Misses       1501     1680     +179     
  Partials      149      149              
Impacted Files Coverage Δ
cli/ingress-controller/main.go 0.24% <0.00%> (ø)
pkg/sendconfig/common_workflows.go 0.00% <0.00%> (ø)
internal/ingress/controller/kong.go 8.16% <33.33%> (ø)
internal/ingress/controller/event_handler.go 0.00% <0.00%> (ø)
internal/ingress/controller/controller.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1f61a...9699c70. Read the comment docs.

internal/ingress/controller/kong.go Outdated Show resolved Hide resolved
railgun/manager/run.go Outdated Show resolved Hide resolved
@mflendrich
Copy link
Contributor

@tharun208 seems that we've started changing this PR at the same instant. Let me finish the modifications and merge recent changes into this PR, sounds good? There's no other action required on your side on this PR, the change looks good 👍

@tharun208
Copy link
Contributor Author

@tharun208 seems that we've started changing this PR at the same instant. Let me finish the modifications and merge recent changes into this PR, sounds good? There's no other action required on your side on this PR, the change looks good 👍

I was about to address the feedback changes. thanks for doing it 🙏

@mflendrich mflendrich merged commit 3c67f12 into Kong:next Jul 1, 2021
@tharun208 tharun208 deleted the feat/tag_support_for_kic_2.0 branch July 1, 2021 14:51
@shaneutt shaneutt mentioned this pull request Jul 7, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support selector tags in KIC 2.0
2 participants