Remove unused code in file and ssl package #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed `internal/file` package. These codes are used to generaete nginx conf, ssl cert files and are not needed now. The way to check ssl certs and generate checksum is also changed to in-memory. - Removed the functionality of checkOCSP and make full-chain certificate, since there's no corresponding behaviour in Kong. Signed-off-by: Wangchong Zhou <[email protected]>
hbagdi
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/filepackage. These codes are used to generaete nginx conf,ssl cert files and are not needed now. The way to check ssl certs and generate
checksum is also changed to in-memory.
there's no corresponding behaviour in Kong.