-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Fix enablement variable setting priority #1578
Conversation
…er priority than CRD existence
Codecov Report
@@ Coverage Diff @@
## next #1578 +/- ##
===========================================
- Coverage 51.51% 39.78% -11.74%
===========================================
Files 93 91 -2
Lines 8737 8327 -410
===========================================
- Hits 4501 3313 -1188
- Misses 3926 4842 +916
+ Partials 310 172 -138
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Licenses differ between commit 18cc5df89a4bac4af012f7de543c8d571335ed71 and base:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that reducing log noise when controllers are specifically disabled is overall good, so I have no blockers for this change.
I do however have several comments, and before this PR is merged I would ask that each gets resolved, either by:
- merging the provided suggestion
- creating a follow up
Before KIC 2.0 releases we need to harden how this stuff works, and improve the documentation so that we're consistent and so contributors and end-users don't get confused.
In retrospect, I created a follow up item anyway because we're going to need it in any case: While all the suggestions I made I feel are still valid, given this follow up item if you're feeling crunched for time please feel free to merge with OR without them at your discretion. |
What this PR does / why we need it:
KIC starts a controller only CRD exists on the cluster though user off the CR plugin through enablement environment variable.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Enablement environment variable flag exposed user (i.e --controller-kongclusterplugin, --controller-knativeingress)should have highest priority.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR