-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use AutoHandlers instead of custom enablement logic #1585
Merged
Merged
Commits on Jul 28, 2021
-
refactor: KongClusterPlugin using AutoHandler
also changes the signature of AutoHandler to use client.Client because client.Reader was too narrow for the refactored implementation
Configuration menu - View commit details
-
Copy full SHA for d8cdf05 - Browse repository at this point
Copy the full SHA d8cdf05View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9c349e - Browse repository at this point
Copy the full SHA d9c349eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c35f20d - Browse repository at this point
Copy the full SHA c35f20dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3871221 - Browse repository at this point
Copy the full SHA 3871221View commit details
Commits on Aug 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b6716c2 - Browse repository at this point
Copy the full SHA b6716c2View commit details
Commits on Aug 3, 2021
-
refactor(mgr) use booleans for controller flags
* refactor(mgr) use booleans for controller flags Change flags for managing controllers from a custom enabled/auto/disabled type to booleans. By default, all controllers are enabled. If a controller's enable flag is set to false, it is disabled. Enabled controllers that have an auto loader are loaded if they are enabled and their auto loader indicates they should load. Remove the KongStateEnabled flag. This was a leftover from an earlier design where the controller managed Kong state information via a special Secret. It had no remaining associated code and was only present in configuration. Rename controller flags to reflect that they enable controllers. Remove enablement status type, associated utility functions, and custom flag handler. * fix(test) only defer body close if exists Move deferred body close checks after the error checkers. If an error is present, no body exists, and the deferred attempt to close it segfaults. Co-authored-by: Michał Flendrich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7448c15 - Browse repository at this point
Copy the full SHA 7448c15View commit details
Commits on Aug 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3ebf32f - Browse repository at this point
Copy the full SHA 3ebf32fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4420e00 - Browse repository at this point
Copy the full SHA 4420e00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5765b44 - Browse repository at this point
Copy the full SHA 5765b44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fc9fd2 - Browse repository at this point
Copy the full SHA 2fc9fd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08a6e22 - Browse repository at this point
Copy the full SHA 08a6e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed08d60 - Browse repository at this point
Copy the full SHA ed08d60View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2c9dd8 - Browse repository at this point
Copy the full SHA e2c9dd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5f3145 - Browse repository at this point
Copy the full SHA b5f3145View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.