Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy) use Job to run Kong migration #161

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Oct 12, 2018

Using InitContainer can result in two Kong nodes running migrations
concurrently.
Job is the right way to run migrations.

Using InitContainer can result in two Kong nodes running migrations
concurrently.
Job is the right way to run migrations.
@codecov-io
Copy link

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   15.31%   15.31%           
=======================================
  Files          34       34           
  Lines        2820     2820           
=======================================
  Hits          432      432           
  Misses       2350     2350           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647c94a...6282336. Read the comment docs.

@hbagdi hbagdi changed the title feat(deploy) use Job to run Kong version feat(deploy) use Job to run Kong migration Oct 15, 2018
@hbagdi hbagdi merged commit 35e71c8 into master Oct 15, 2018
@hbagdi hbagdi deleted the feat/job-based-migration branch October 15, 2018 19:31
hbagdi added a commit that referenced this pull request Oct 25, 2018
This was already done previously in #129 
but got reverted #161.

From #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants