Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booleanize the controller flags #1638

Merged
merged 4 commits into from
Aug 3, 2021

Commits on Aug 2, 2021

  1. refactor(mgr) use booleans for controller flags

    Change flags for managing controllers from a custom
    enabled/auto/disabled type to booleans. By default, all controllers are
    enabled. If a controller's disable flag is set, it is disabled. Enabled
    controllers that have an auto loader are loaded if they are enabled and
    their auto loader indicates they should load.
    
    Remove the KongStateEnabled flag. This was a leftover from an earlier
    design where the controller managed Kong state information via a special
    Secret. It had no remaining associated code and was only present in
    configuration.
    
    Rename controller flags to reflect that they disable controllers when
    set.
    
    Remove enablement status type, associated utility functions, and custom
    flag handler.
    Travis Raines committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    dd06318 View commit details
    Browse the repository at this point in the history
  2. fix(test) only defer body close if exists

    Move deferred body close checks after the error checkers. If an error is
    present, no body exists, and the deferred attempt to close it segfaults.
    Travis Raines committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    668decb View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. refactor(mgr) flip flags from disabled to enabled

    Change the controller flags from disablers to enablers and flip the
    logic that handles them.
    
    Remove unnecessary pointer usage.
    Travis Raines committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    7c34d87 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Michał Flendrich <[email protected]>
    Travis Raines and mflendrich authored Aug 3, 2021
    Configuration menu
    Copy the full SHA
    9360b22 View commit details
    Browse the repository at this point in the history