Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallelize the integration test suite #1669

Merged
merged 12 commits into from
Aug 5, 2021

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Aug 5, 2021

What this PR does / why we need it:

This PR makes several changes to our integration test suite:

  • general cleanup and refactoring
  • ensures all tests receive (and use) their own unique namespace (namespace default is no longer supported)
  • ensures all tests cleanup after themselves and tear down their resources
  • enables parallelization of the integration test cases
  • moves the bulk ingress tests into test/performance as these tests are costly and noisy, and now with parallelization of tests some of their value has been replaced

Which issue this PR fixes

Resolves #1592

Notes

I ran ./hack/e2e/run-tests.sh locally to verify these changes in our release testing, and it's working properly on GKE.

@shaneutt shaneutt changed the title Parallelize integration tests feat: parallelize the integration test suite Aug 5, 2021
@shaneutt shaneutt self-assigned this Aug 5, 2021
@shaneutt shaneutt added area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/perf Performance Related Issues labels Aug 5, 2021
@shaneutt shaneutt linked an issue Aug 5, 2021 that may be closed by this pull request
5 tasks
@shaneutt shaneutt force-pushed the parallelize-integration-tests branch 2 times, most recently from c1aabb8 to 092241d Compare August 5, 2021 20:45
@Kong Kong deleted a comment from codecov bot Aug 5, 2021
@shaneutt shaneutt marked this pull request as ready for review August 5, 2021 20:50
@shaneutt shaneutt requested a review from a team as a code owner August 5, 2021 20:50
@Kong Kong deleted a comment from codecov bot Aug 5, 2021
@shaneutt shaneutt enabled auto-merge (rebase) August 5, 2021 20:52
@Kong Kong deleted a comment from codecov bot Aug 5, 2021
@Kong Kong deleted a comment from codecov bot Aug 5, 2021
@shaneutt shaneutt force-pushed the parallelize-integration-tests branch from 092241d to 7c6e0b7 Compare August 5, 2021 21:27
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1669 (7c6e0b7) into next (52bf3fc) will decrease coverage by 16.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             next    #1669       +/-   ##
===========================================
- Coverage   62.36%   46.17%   -16.19%     
===========================================
  Files          81       70       -11     
  Lines        7272     6837      -435     
===========================================
- Hits         4535     3157     -1378     
- Misses       2403     3307      +904     
- Partials      334      373       +39     
Flag Coverage Δ
integration-test 46.17% <ø> (-16.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/cmd/rootcmd/env.go 0.00% <0.00%> (-100.00%) ⬇️
internal/util/secretgetter.go 0.00% <0.00%> (-100.00%) ⬇️
internal/kongstate/consumer.go 0.00% <0.00%> (-100.00%) ⬇️
internal/kongstate/credentials.go 0.00% <0.00%> (-97.96%) ⬇️
internal/util/k8s.go 6.81% <0.00%> (-93.19%) ⬇️
internal/util/ingressapi.go 0.00% <0.00%> (-90.91%) ⬇️
internal/admission/validator.go 12.85% <0.00%> (-77.15%) ⬇️
internal/util/relations.go 27.27% <0.00%> (-72.73%) ⬇️
internal/store/fake_store.go 7.47% <0.00%> (-57.95%) ⬇️
internal/kongstate/route.go 39.43% <0.00%> (-55.29%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bf3fc...7c6e0b7. Read the comment docs.

@shaneutt shaneutt merged commit b00580a into next Aug 5, 2021
@shaneutt shaneutt deleted the parallelize-integration-tests branch August 5, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/perf Performance Related Issues ci/license/unchanged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel Integration Tests
2 participants