Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support minimum TLS v1.2 for webhook admission server #1671

Merged
merged 2 commits into from
Aug 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@
until the resource has been corrected.
[#550](https:/Kong/kubernetes-ingress-controller/issues/550)

#### Breaking changes

- TLS v1.2+ compatible clients are required now going forward in order
to do SSL negotiations with the webhook admission server.
[#1065](https:/Kong/kubernetes-ingress-controller/issues/1065)

## [2.0.0-alpha.3] - 2021/08/02

#### Breaking changes
Expand Down
3 changes: 2 additions & 1 deletion internal/admission/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ func (sc *ServerConfig) toTLSConfig() (*tls.Config, error) {
if err != nil {
return nil, fmt.Errorf("X509KeyPair error: %w", err)
}
return &tls.Config{ //nolint:gosec
return &tls.Config{
MinVersion: tls.VersionTLS12,
Certificates: []tls.Certificate{keyPair},
}, nil
}
Expand Down